Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nil pointer deference in subset diff. #36

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Nil pointer deference in subset diff. #36

merged 1 commit into from
Aug 12, 2019

Conversation

tomwilkie
Copy link
Contributor

$ tk diff environments/cortex/eu-west2.dev/
Warning: `namespace` is deprecated, use `spec.namespace` instead.
Warning: `server` is deprecated, use `spec.apiServer` instead.
Warning: `team` is deprecated, use `metadata.labels.team` instead.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x148b9d6]

goroutine 1 [running]:
github.com/grafana/tanka/pkg/kubernetes.Kubectl.SubsetDiff(0x0, 0x0, 0xc0000f6240, 0x15, 0xc00062c000, 0x918f, 0x9, 0xc0002e5e18, 0x8)
    /Users/twilkie/Documents/src/github.com/sh0rez/tanka/pkg/kubernetes/subsetdiff.go:71 +0x7a6
github.com/grafana/tanka/pkg/kubernetes.(*Kubernetes).Diff(0xc0000b3380, 0xc000523000, 0x20, 0x20, 0x0, 0x0, 0x20)
    /Users/twilkie/Documents/src/github.com/sh0rez/tanka/pkg/kubernetes/kubernetes.go:132 +0x1af
main.diff(0xc000523000, 0x20, 0x20, 0x1, 0x0)
    /Users/twilkie/Documents/src/github.com/sh0rez/tanka/cmd/tk/workflow.go:101 +0x66
main.diffCmd.func1(0xc0000eec80, 0xc0004e62f0, 0x1, 0x1)
    /Users/twilkie/Documents/src/github.com/sh0rez/tanka/cmd/tk/workflow.go:87 +0x1f8
github.com/spf13/cobra.(*Command).execute(0xc0000eec80, 0xc0000b4020, 0x1, 0x1, 0xc0000eec80, 0xc0000b4020)
    /Users/twilkie/Documents/pkg/mod/github.com/spf13/[email protected]/command.go:830 +0x2ae
github.com/spf13/cobra.(*Command).ExecuteC(0xc0000ee000, 0xc0004e62c0, 0xc00026d8c0, 0x0)
    /Users/twilkie/Documents/pkg/mod/github.com/spf13/[email protected]/command.go:914 +0x2fc
github.com/spf13/cobra.(*Command).Execute(...)
    /Users/twilkie/Documents/pkg/mod/github.com/spf13/[email protected]/command.go:864
main.main()

Signed-off-by: Tom Wilkie [email protected]

@tomwilkie tomwilkie requested a review from sh0rez August 12, 2019 12:14
Copy link
Member

@sh0rez sh0rez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wtf what did I even do there

LGTM

@sh0rez sh0rez merged commit f53c2b5 into master Aug 12, 2019
@sh0rez sh0rez deleted the npe-subsetdiff branch August 12, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants