You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The overrides module has outgrown its original scope of providing limits to Tempo components, to hosting any kind of dynamic configuration that can be modified at runtime. So, in the same config block we have ingestion limits like ingestion_rate_limit_bytes and max_traces_per_user, metrics-generator config such as metrics_generator_ring_size and metrics_generator_processor_service_graphs_histogram_buckets, and soon even storage config with the introduction of vParquet3.
All of this makes for a complex config structure, with overly long param names (eg. metrics_generator_processor_service_graphs_enable_client_server_prefix), and unclear scope.
Proposals
Add indentation to overrides block to make reading and writing configs easier
I think we can combine this with #2638, this moves the default values from the top-level to it's own nested key. If we are changing the yaml structure anyway, we can do both at once imo.
During transition we could follow this logic for parsing the config:
attempt to parse the config using the new nested structure
if this fails, attempt to parse into the flat structure
if this also fails we return an error
We can print a warning when people use the flat structure to encourage them to transition.
The overrides module has outgrown its original scope of providing limits to Tempo components, to hosting any kind of dynamic configuration that can be modified at runtime. So, in the same config block we have ingestion limits like
ingestion_rate_limit_bytes
andmax_traces_per_user
, metrics-generator config such asmetrics_generator_ring_size
andmetrics_generator_processor_service_graphs_histogram_buckets
, and soon even storage config with the introduction ofvParquet3
.All of this makes for a complex config structure, with overly long param names (eg.
metrics_generator_processor_service_graphs_enable_client_server_prefix
), and unclear scope.Proposals
Add indentation to overrides block to make reading and writing configs easier
Old overrides:
New overrides:
Drop word limits from the overrides module. It's not longer accurate and confusing when developing. (Not referring to override names).
The text was updated successfully, but these errors were encountered: