Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hedged requests roundtrips total with a counter #4060

Closed
joe-elliott opened this issue Sep 5, 2024 · 2 comments · Fixed by #4063 or #4078
Closed

Replace hedged requests roundtrips total with a counter #4060

joe-elliott opened this issue Sep 5, 2024 · 2 comments · Fixed by #4063 or #4078
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed type/bug Something isn't working

Comments

@joe-elliott
Copy link
Member

We are currently using a gauge incorrectly to report hedged roundtrips on both external endpoints and backend requests. This has worked in the past but recently we have seen this report erroneous results when rate()ing in prometheus. It's possible it never worked correctly and we have only recently noticed. Regardless, it's bad practice and we should fix it.

External Hedged Requests Gauge

Backend Hedged Requests Gauge

Shared code in use for both Gauges

Let's replace the two linked gauges above with counters.

@joe-elliott joe-elliott added good first issue Good for newcomers help wanted Extra attention is needed type/bug Something isn't working labels Sep 5, 2024
@galalen
Copy link
Contributor

galalen commented Sep 8, 2024

I would like to work on it

@joe-elliott
Copy link
Member Author

Thanks @galalen. Let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed type/bug Something isn't working
Projects
None yet
2 participants