Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

Client is outdated #1

Open
lwindolf opened this issue Jun 8, 2021 · 7 comments
Open

Client is outdated #1

lwindolf opened this issue Jun 8, 2021 · 7 comments

Comments

@lwindolf
Copy link

lwindolf commented Jun 8, 2021

Latest API provided by code in grafeas uses "v1beta" API, so this client needs to be regenerated.

@aysylu
Copy link

aysylu commented Jun 10, 2021

@lwindolf if you'd like to regenerate it and open PR, we welcome contributions!

@lwindolf
Copy link
Author

I've seen several people try in the closed PRs. Given the problems with the broken swagger API JSON (POST URLs with wrong definitions) regeneration is IMO not possible. This is something only the Grafeas project can fix.

@aysylu
Copy link

aysylu commented Jun 11, 2021

Yes, the Swagger API <-> proto bindings incompatibility is the reason these can't easily be auto-generated. There are 3 possible paths here:

  1. auto-generate and then fix the issues (e.g. Initial Swagger compatibility proposal client-go#15),
  2. generate brand new client with the client methods implemented idiomatically,
  3. use protoc-generated code.

If you'd like to contribute 1) or 2), happy to review!

@lwindolf
Copy link
Author

lwindolf commented Jun 11, 2021

Sorry the CLA prevents me from contributing. Also I don't like the unapproachability of the project. Asking for potential users to fix what they need to approach the project in the first place is IMO not ok if this is to be considered an OpenSource project looking for a community.

@lwindolf
Copy link
Author

lwindolf commented Apr 6, 2022

FYI I blog posted on how to workaround the issue: https://lzone.de/blog/Accessing-Grafeas-with-a-swagger-client. Maybe this helps others.

@aysylu
Copy link

aysylu commented Apr 6, 2022

Adding current set of maintainers @wkozlik @nyc for visibility, as I'm no longer maintaining this project.

@nyc
Copy link

nyc commented Apr 7, 2022

I believe the issue that was mentioned previously should be fixed with grafeas/grafeas#532 so we can regenerate the client now. I'm also working on merging the Swagger files in v1beta1 so you don't have to generate two separate clients for the grafeas and projects services and eventually generating them in v1 so we can generate clients for all of the versions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants