-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't compile ROOT_URL/etc into Next bundle (use window variable) #162
Comments
Hey @benjie - I've made this change locally to a project and also modified the production Dockerfile to support building a single image for multiple environments and multiple entry points (server, worker). This means you can build and store one image that can be promoted and also used for either the server or worker. Would you be interested in a PR? |
Yes please 🙌 |
Hey @aortbals have you had a change to look at this yet? |
I'll get a PR up this week, thanks for the reminder! |
Awesome 👍 |
I thought I could work on this after refactoring environment variables (#234), but it seems like it's already done in |
Ah yes, I did this, thanks 👍 |
Otherwise we can't easily promote staging to production (requires rebuild)
The text was updated successfully, but these errors were encountered: