Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't compile ROOT_URL/etc into Next bundle (use window variable) #162

Closed
benjie opened this issue May 10, 2020 · 7 comments
Closed

Don't compile ROOT_URL/etc into Next bundle (use window variable) #162

benjie opened this issue May 10, 2020 · 7 comments

Comments

@benjie
Copy link
Member

benjie commented May 10, 2020

Otherwise we can't easily promote staging to production (requires rebuild)

@aortbals
Copy link

Hey @benjie - I've made this change locally to a project and also modified the production Dockerfile to support building a single image for multiple environments and multiple entry points (server, worker). This means you can build and store one image that can be promoted and also used for either the server or worker. Would you be interested in a PR?

@benjie
Copy link
Member Author

benjie commented May 14, 2020

Yes please 🙌

@benjie
Copy link
Member Author

benjie commented Jun 1, 2020

Hey @aortbals have you had a change to look at this yet?

@aortbals
Copy link

aortbals commented Jun 2, 2020

I'll get a PR up this week, thanks for the reminder!

@benjie
Copy link
Member Author

benjie commented Jun 2, 2020

Awesome 👍

@DylanVann
Copy link
Contributor

I thought I could work on this after refactoring environment variables (#234), but it seems like it's already done in @app/client/src/next.config.js.

@benjie
Copy link
Member Author

benjie commented Jan 15, 2021

Ah yes, I did this, thanks 👍

@benjie benjie closed this as completed Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants