Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move more tests here #75

Open
wagenet opened this issue Feb 4, 2022 · 2 comments
Open

Move more tests here #75

wagenet opened this issue Feb 4, 2022 · 2 comments

Comments

@wagenet
Copy link
Collaborator

wagenet commented Feb 4, 2022

Right now, most tests live in the main graphiti repo. We should move the graphiti-rails ones here.
@richmolj
Copy link
Collaborator

richmolj commented Feb 4, 2022

I agree conceptually, but particularly for integration specs I'm not sure. Seems like we could get into a situation where an update to graphiti codebase breaks the overall behavior users expect, but we don't know about it because the PR ran specs for graphiti, not graphiti+graphiti-rails

@wagenet
Copy link
Collaborator Author

wagenet commented Feb 4, 2022

@richmolj we’d probably want some on both sides ideally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wagenet @richmolj