Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize contract and abi names provided in manifest #1390

Closed
saihaj opened this issue Jun 24, 2023 · 0 comments · Fixed by #1503
Closed

Sanitize contract and abi names provided in manifest #1390

saihaj opened this issue Jun 24, 2023 · 0 comments · Fixed by #1503
Assignees
Labels
area/cli area/codegen bug Something isn't working

Comments

@saihaj
Copy link
Member

saihaj commented Jun 24, 2023

If a user gives YourContract.sol as a name for ABI this will break code generation.

In the case this happens we can sanitize the input so the generated TS is still valid. Or we can tell user not to input that as a name. If we decide to not let users input that as a name then on init we also need to sanitize the name we give from the ABI file name

@saihaj saihaj added bug Something isn't working area/cli area/codegen labels Jun 24, 2023
@saihaj saihaj self-assigned this Jun 24, 2023
@saihaj saihaj added this to Tooling Jun 24, 2023
@saihaj saihaj moved this to 🏗 In progress in Tooling Jun 28, 2023
@theguild-bot theguild-bot mentioned this issue Oct 31, 2023
26 tasks
@saihaj saihaj moved this from 🏗 In progress to 👀 In review in Tooling Nov 14, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Tooling Nov 15, 2023
This was referenced Apr 30, 2024
This was referenced May 7, 2024
@theguild-bot theguild-bot mentioned this issue Oct 15, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli area/codegen bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant