Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback introspection query never actually happens #79

Closed
dallonf opened this issue Jan 14, 2016 · 2 comments
Closed

Fallback introspection query never actually happens #79

dallonf opened this issue Jan 14, 2016 · 2 comments

Comments

@dallonf
Copy link

dallonf commented Jan 14, 2016

Just starting messing with GraphiQL and the graphql-java implementation, which doesn't support subscriptionType yet. According to #55, this was fixed with a fallback query, but it seems to be implemented by catching the fetcher's result.

The thing is... it appears that the fetcher is not actually supposed to (and, at least in the example directory, does not) throw, at least in the case of a standard GraphQL error!

For reference, the result that is returned when introspection fails is this:

{
  "errors": [
    {
      "validationErrorType": "FieldUndefined",
      "message": "Validation error of type FieldUndefined: Field subscriptionType is undefined",
      "locations": [
        {
          "line": 6,
          "column": 7
        }
      ],
      "errorType": "ValidationError"
    }
  ],
  "data": null
}

I also tried manually throwing in the fetcher if the result contains errors; this works, but degrades the user experience as normal validation errors will not show up in the right-hand panel.

@sazzer
Copy link

sazzer commented Jan 21, 2016

I've just come across this myself, and I can't actually find subscriptionType mentioned in the GraphQL Specification anywhere. It looks like this turned up in the graphql-js codebase back in September, as commit 8a589f6, and GraphiQL has just inherited it automatically as a dependency.

@leebyron
Copy link
Contributor

leebyron commented Mar 9, 2016

Thanks for reporting this and sorry for the delay in fixing. Subscriptions is an experimental feature, and GraphiQL has growing experimental support.

acao pushed a commit to acao/graphiql that referenced this issue Jun 5, 2019
…ransform-es2015-literals-6.22.0

Update babel-plugin-transform-es2015-literals to version 6.22.0 🚀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants