Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

happy svelte parsing #3366

Merged
merged 3 commits into from
Jan 7, 2024
Merged

happy svelte parsing #3366

merged 3 commits into from
Jan 7, 2024

Conversation

acao
Copy link
Member

@acao acao commented Jul 24, 2023

This is a revival of an effort from #3204 by @tadeokondrak to add more comprehensive svelte parsing by using the svelte compiler

I think this test case covers some more advanced usage?

Todo:

  • mark new svelte parsers as external for esbuild, manually test esbuild bundling & vsix

@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2023

⚠️ No Changeset found

Latest commit: 1046638

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for graphiql-test ready!

Name Link
🔨 Latest commit 6482883
🔍 Latest deploy log https://app.netlify.com/sites/graphiql-test/deploys/64cb85622433760008ca3767
😎 Deploy Preview https://deploy-preview-3366--graphiql-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (9b6ce25) 55.81% compared to head (1046638) 55.85%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3366      +/-   ##
==========================================
+ Coverage   55.81%   55.85%   +0.04%     
==========================================
  Files         110      114       +4     
  Lines        5273     5303      +30     
  Branches     1439     1441       +2     
==========================================
+ Hits         2943     2962      +19     
- Misses       1901     1911      +10     
- Partials      429      430       +1     
Files Coverage Δ
...raphql-language-service-server/src/GraphQLCache.ts 50.88% <100.00%> (ø)
...ql-language-service-server/src/MessageProcessor.ts 45.83% <ø> (ø)
...s/graphql-language-service-server/src/constants.ts 100.00% <100.00%> (ø)
...aphql-language-service-server/src/parseDocument.ts 86.66% <100.00%> (+7.71%) ⬆️
...phql-language-service-server/src/parsers/svelte.ts 75.00% <75.00%> (ø)
...aphql-language-service-server/src/parsers/babel.ts 77.77% <77.77%> (ø)
...hql-language-service-server/src/findGraphQLTags.ts 82.71% <75.00%> (+0.30%) ⬆️
...graphql-language-service-server/src/parsers/vue.ts 57.69% <57.69%> (ø)

@acao acao added the lsp-server graphql-language-service-server label Jul 27, 2023
@acao acao force-pushed the svelte-parser branch 5 times, most recently from 4528804 to c63db4d Compare January 7, 2024 08:12
@acao acao merged commit efe142d into main Jan 7, 2024
14 checks passed
@acao acao deleted the svelte-parser branch January 7, 2024 16:18
acao added a commit that referenced this pull request Jan 7, 2024
* happy svelte parsing
* test range
* refactor tag parsing for readability & perf tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lsp-server graphql-language-service-server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant