Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle the race condition in updating operationName #344

Merged
merged 1 commit into from
Feb 27, 2017
Merged

handle the race condition in updating operationName #344

merged 1 commit into from
Feb 27, 2017

Commits on Feb 27, 2017

  1. handle the race condition in updating operationName 

    If a new query string is passed in (and `componentWillReceiveProps` is called) without manually editing query (e.g. programmatically modifying the content within the editor without key events), it's possible to have both `_updateQueryFacts` and `componentWillReceiveProps` tryint to update `operationName` by calling the `setState` method, most often times the one in `componentWillReceiveProps` winning incorrectly. The fix is to treat the outcome from `_updateQueryFacts` as truth and properly updating what to update during the component lifecycle.

be more specific when getting object properties
    @asiandrummer
    asiandrummer committed Feb 27, 2017
    Configuration menu
    Copy the full SHA
    8b83e94 View commit details
    Browse the repository at this point in the history