Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] remove disableTabs option #3687

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

dimaMachina
Copy link
Collaborator

this never worked as expected, since when you open a new chrome tab -> you will get query/variables from the previous tab

Copy link

changeset-bot bot commented Aug 7, 2024

🦋 Changeset detected

Latest commit: 8d94ec0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphiql Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.84%. Comparing base (955573a) to head (8d94ec0).
Report is 4 commits behind head on graphiql-v4.

Files Patch % Lines
packages/graphiql/src/components/GraphiQL.tsx 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           graphiql-v4    #3687      +/-   ##
===============================================
- Coverage        60.85%   60.84%   -0.02%     
===============================================
  Files              121      121              
  Lines             5620     5618       -2     
  Branches          1490     1488       -2     
===============================================
- Hits              3420     3418       -2     
  Misses            1748     1748              
  Partials           452      452              
Files Coverage Δ
packages/graphiql/src/components/GraphiQL.tsx 67.32% <42.85%> (-0.43%) ⬇️

Copy link
Contributor

github-actions bot commented Aug 7, 2024

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@dimaMachina dimaMachina merged commit 09e7004 into graphiql-v4 Aug 7, 2024
14 checks passed
@dimaMachina dimaMachina deleted the remove-disable-tabs branch August 7, 2024 15:07
@acao acao mentioned this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant