Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] Remove toolbar.additionalContent and toolbar.additionalComponent props in favor of GraphiQL.Toolbar render props. #3707

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

dimaMachina
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Aug 9, 2024

🦋 Changeset detected

Latest commit: 19aa063

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphiql Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimaMachina dimaMachina requested a review from acao August 9, 2024 12:28
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 93.18182% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.64%. Comparing base (7afb4be) to head (19aa063).

Files Patch % Lines
packages/graphiql/src/components/GraphiQL.tsx 93.18% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           graphiql-v4    #3707      +/-   ##
===============================================
+ Coverage        67.60%   67.64%   +0.04%     
===============================================
  Files              121      121              
  Lines             6960     6975      +15     
  Branches          2225     2255      +30     
===============================================
+ Hits              4705     4718      +13     
- Misses            2238     2240       +2     
  Partials            17       17              
Files Coverage Δ
packages/graphiql/src/components/GraphiQL.tsx 78.78% <93.18%> (+0.54%) ⬆️

Copy link
Contributor

github-actions bot commented Aug 9, 2024

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@dimaMachina dimaMachina merged commit 3c901c1 into graphiql-v4 Aug 13, 2024
14 checks passed
@dimaMachina dimaMachina deleted the toolbar-render-props branch August 13, 2024 16:15
@acao acao mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant