Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove path(/dev.html) from local development GraphiQL URL #3800

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hxrxchang
Copy link

@hxrxchang hxrxchang commented Oct 29, 2024

When I first tried to set up the development environment for GraphiQL, I noticed that the documentation in DEVELOPMENT.md mentioned that GraphiQL is hosted at http://localhost:8080/dev.html
However, it was actually hosted at http://localhost:8080, so I updated the documentation to reflect this.

Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: 4f5da66

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

linux-foundation-easycla bot commented Oct 29, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@acao
Copy link
Member

acao commented Nov 2, 2024

@hxrxchang it looks like a dev tooling regression, as the /dev path is meant to resolve the unminified bundle for debugging

@hxrxchang
Copy link
Author

hxrxchang commented Nov 4, 2024

@acao
Thanks for your review.
If you want to use dev.html as the entry point when in the development environment (i.e., when the server is started with webpack-dev-server), then it seems that the part at https://github.com/hxrxchang/graphiql/blob/fix-local-development-url/packages/graphiql/resources/webpack.config.js#L85 should be isHMR instead of !isHMR.
isHMR refers to process.env.WEBPACK_SERVE, which is an environment variable that webpack-dev-server sets automatically. Refer to https://github.com/webpack/webpack-dev-server/blob/a11d81f063585a80a427d2d9dfc79f58799278cc/lib/Server.js#L241-L243.

@acao
Copy link
Member

acao commented Nov 9, 2024

@hxrxchang yes, it seems the local development regression was introduced the last time I upgraded webpack

it is working on preview release though:

https://graphiql-test.netlify.app/dev

as you can see, the code is bundled but not minified, as designed, and the react development versions are used for debugging, however, it seems the js and css source maps are not deploying to netlify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants