Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

avoid null route, ref, and status in new exchanges #3822

Closed
chadwhitacre opened this issue Oct 12, 2015 · 5 comments
Closed

avoid null route, ref, and status in new exchanges #3822

chadwhitacre opened this issue Oct 12, 2015 · 5 comments

Comments

@chadwhitacre
Copy link
Contributor

See #3810 for why cross-linking transactions is a good idea. We were doing this for Balanced by the end, but I don't think we're doing this for any payment networks now.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@rohitpaulk
Copy link
Contributor

We had the 'reverse' of this in Balanced, iirc. There was a meta column named 'exchange_id' on every transaction in Balanced.

@chadwhitacre
Copy link
Contributor Author

@rohitpaulk Yes! We preferred that on #3807:

# First strategy: use the one in the transaction!
exchange_id = transaction['meta'].get('exchange_id')
if exchange_id:
counts.exchange_in_transaction += 1
log("exchange_id in transaction", 26)
return exchange_id

@chadwhitacre
Copy link
Contributor Author

Really we should refactor payment routes along the lines of accounts elsewhere, to have a more consistent interface across all of the routes we support, to include method and transaction linking, and status changes via postbacks.

@chadwhitacre
Copy link
Contributor Author

We haven't had a NULL route (at least) since #3810. See #3975 (comment).

@chadwhitacre
Copy link
Contributor Author

Folding this into #4442.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants