This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
Update electron-builder to 24.0.0-alpha.5 #1434
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first I thought that the fix for gravitational/teleport#18859 broke symlinking
teleport-connect
in the rpm package but it actually turned out to be a regression in electron-builder. alpha.5 creates the symlink properly and everything else works fine as well.I remember there was a reason why we had to use an alpha version of electron-builder but I don't remember the details, it was related to the Windows build I think?
By now there's alpha.7 of electron-builder but: