Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document different users for ci and eco part #66

Open
ribalba opened this issue May 2, 2024 · 2 comments
Open

Document different users for ci and eco part #66

ribalba opened this issue May 2, 2024 · 2 comments

Comments

@ribalba
Copy link
Member

ribalba commented May 2, 2024

Currently we don't really state which user has to run eco-ci as we always assumed that we would run as the user of the ci job. This implies that the ci runner could access the code of the ci run which could pose a potential security risk if the ci runner is compromised on our end. We could harden this by creating a new user that has no access to the ci data but can only read the cpu utilisation and then report on this. There is nothing really stopping eco-ci from working like this we just need to document how this can be done and maybe write a little script.

Request came from Anita

@ArneTR
Copy link
Member

ArneTR commented May 2, 2024

For what scenario is this idea?

For Github it does not make any real sense I would argue as the execution environment must be able to read the Github ENV vars ... I foresee this a very niche and hacky implementation.
Furthermore the tool installs quite some packages. This would have to be done then beforehand with a different user ... as said. I forsee hackyness.

For an on-premise case I do not quite understand the need here. Us implementing something that could be seen as "secure" is still a case of trust that is likely not perfect.
The most "trustful" way would be to just clone the repository and run a validated copy of the code. Would it not?

Final question: Am I missing a case or missing something else?

@anitaschuettler
Copy link

anitaschuettler commented May 2, 2024

This is due to me asking if there was a way around having an external tool in a pipeline with root access. That's how we're currently running it and it's foreseeable that this will be a problem once we're in a real customer environment.

(Gitlab, AWS)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants