We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitHelpers.getNumberOfCommitsOnBranch does not work on CircleCI.
The refactoring of gitHelpers.getNumberOfCommitsOnBranch in #35 changed its output on CircleCI. Test: https://github.com/patkub/test-gk-lock-git-helpers/blob/master/index.js
gitHelpers.getNumberOfCommitsOnBranch
On a greenkeeper branch, both methods fail and return 0. CircleCI build: https://circleci.com/gh/patkub/test-gk-lock-git-helpers/35
Number of commits on branch: 0 Number of commits on branch (old method): 0
But, on the master branch, the old method properly detects the number of commits, while the new method returns 0. CircleCI build: https://circleci.com/gh/patkub/test-gk-lock-git-helpers/33
Number of commits on branch: 0 Number of commits on branch (old method): 15
The old method prior to #35 was
greenkeeper-lockfile/lib/git-helpers.js
Lines 6 to 14 in e2e41a7
Current method is:
Lines 8 to 16 in 6a1068a
The text was updated successfully, but these errors were encountered:
@nevir Any thoughts on how to fix this for CircleCI and not potentially break other CIs?
Sorry, something went wrong.
No branches or pull requests
gitHelpers.getNumberOfCommitsOnBranch does not work on CircleCI.
The refactoring of
gitHelpers.getNumberOfCommitsOnBranch
in #35 changed its output on CircleCI.Test: https://github.com/patkub/test-gk-lock-git-helpers/blob/master/index.js
On a greenkeeper branch, both methods fail and return 0.
CircleCI build: https://circleci.com/gh/patkub/test-gk-lock-git-helpers/35
But, on the master branch, the old method properly detects the number of commits, while the new method returns 0.
CircleCI build: https://circleci.com/gh/patkub/test-gk-lock-git-helpers/33
The old method prior to #35 was
greenkeeper-lockfile/lib/git-helpers.js
Lines 6 to 14 in e2e41a7
Current method is:
greenkeeper-lockfile/lib/git-helpers.js
Lines 8 to 16 in 6a1068a
The text was updated successfully, but these errors were encountered: