Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not update lockfile when monorepo packages are published #204

Closed
freaktechnik opened this issue Aug 26, 2018 · 1 comment
Closed

Does not update lockfile when monorepo packages are published #204

freaktechnik opened this issue Aug 26, 2018 · 1 comment

Comments

@freaktechnik
Copy link

The lockfile is not updated when multiple packages from a monorepo are updated in a single branch, since it expects there only to be one commit, however there are multiple commits.

Example:
freaktechnik/justintv-stream-notifications#425

@janl
Copy link
Contributor

janl commented Sep 13, 2018

heya @freaktechnik, two options:

  1. If you only have public dependencies, Greenkeeper now updates lockfiles automatically:https://blog.greenkeeper.io/announcing-native-lockfile-support-85381a37a0d0

  2. if you have private deps, you still need greenkeeper-lockfile to opt into monorepo support, you need to install version 2 explicitly, here:

https://github.com/freaktechnik/justintv-stream-notifications/blob/master/.travis.yml#L25

before_install: npm i -g greenkeeper-lockfile@2

See #164 for details.

@janl janl closed this as completed Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants