Skip to content

Commit

Permalink
Merge pull request #2197 from barton2526/random_fixes
Browse files Browse the repository at this point in the history
doc: Random fixes
  • Loading branch information
jamescowens authored Jun 24, 2021
2 parents 7bf8a7c + 6823abb commit 0954cd2
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 10 deletions.
2 changes: 1 addition & 1 deletion src/keystore.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class CKeyStore
virtual void GetKeys(std::set<CKeyID> &setAddress) const =0;
virtual bool GetPubKey(const CKeyID &address, CPubKey& vchPubKeyOut) const;

// Support for BIP 0013 : see https://en.bitcoin.it/wiki/BIP_0013
// Support for BIP 0013 : see https://github.com/bitcoin/bips/blob/master/bip-0013.mediawiki
virtual bool AddCScript(const CScript& redeemScript) =0;
virtual bool HaveCScript(const CScriptID &hash) const =0;
virtual bool GetCScript(const CScriptID &hash, CScript& redeemScriptOut) const =0;
Expand Down
4 changes: 2 additions & 2 deletions src/qt/bitcoinaddressvalidator.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

#include <QValidator>

/** Base48 entry widget validator.
Corrects near-miss characters and refuses characters that are no part of base48.
/** Base58 entry widget validator.
Corrects near-miss characters and refuses characters that are no part of base58.
*/
class BitcoinAddressValidator : public QValidator
{
Expand Down
2 changes: 1 addition & 1 deletion src/rpc/protocol.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ int ReadHTTPMessage(std::basic_istream<char>& stream, std::map<std::string,
// unspecified (HTTP errors and contents of 'error').
//
// 1.0 spec: http://json-rpc.org/wiki/specification
// 1.2 spec: http://groups.google.com/group/json-rpc/web/json-rpc-over-http
// 1.2 spec: http://jsonrpc.org/historical/json-rpc-over-http.html
// https://www.codeproject.com/KB/recipes/JSON_Spirit.aspx
//

Expand Down
7 changes: 2 additions & 5 deletions src/test/bignum_tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,8 @@ BOOST_AUTO_TEST_SUITE(bignum_tests)
// stack buffer overruns.
//
// For more accurate diagnostics, you can use an undefined arithmetic operation
// detector such as the clang-based tool:
//
// "IOC: An Integer Overflow Checker for C/C++"
//
// Available at: http://embed.cs.utah.edu/ioc/
// detector such as the clang's undefined behaviour checker.
// See also: http://clang.llvm.org/docs/UsersManual.html#controlling-code-generation
//
// It might also be useful to use Google's AddressSanitizer to detect
// stack buffer overruns, which valgrind can't currently detect.
Expand Down
2 changes: 1 addition & 1 deletion src/test/netbase_tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ BOOST_AUTO_TEST_CASE(netbase_lookupnumeric)

BOOST_AUTO_TEST_CASE(onioncat_test)
{
// values from http://www.cypherpunk.at/onioncat/wiki/OnionCat
// values from https://web.archive.org/web/20121122003543/http://www.cypherpunk.at/onioncat/wiki/OnionCat
CNetAddr addr1("5wyqrzbvrdsumnok.onion");
CNetAddr addr2("FD87:D87E:EB43:edb1:8e4:3588:e546:35ca");
BOOST_CHECK(addr1 == addr2);
Expand Down

0 comments on commit 0954cd2

Please sign in to comment.