From 3bdec99ccc5070201a2671067b34b9d7b7c2707e Mon Sep 17 00:00:00 2001
From: "James C. Owens" <jamesowens@optonline.net>
Date: Fri, 26 Nov 2021 23:12:06 -0500
Subject: [PATCH] Fix breakage introduced by use of FormatISO8601DateTime

in backup functions. Operating systems do not like colons in
filenames. This introduces a function called FormatISO8601DateTimeDashSep
which is also ISO8601 compliant but uses dashes throughout. This is
consistent with prior backup filename naming.
---
 src/gridcoin/backup.cpp |  2 +-
 src/util/time.cpp       | 13 +++++++++++++
 src/util/time.h         |  1 +
 3 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/src/gridcoin/backup.cpp b/src/gridcoin/backup.cpp
index 582691afee..c29b12d1db 100644
--- a/src/gridcoin/backup.cpp
+++ b/src/gridcoin/backup.cpp
@@ -25,7 +25,7 @@ std::string GRC::GetBackupFilename(const std::string& basename, const std::strin
 {
     std::string sBackupFilename;
     fs::path rpath;
-    sBackupFilename = basename + "-" + std::string(FormatISO8601DateTime(GetTime()));
+    sBackupFilename = basename + "-" + std::string(FormatISO8601DateTimeDashSep(GetTime()));
     if (!suffix.empty())
         sBackupFilename = sBackupFilename + "-" + suffix;
     rpath = GetBackupPath() / sBackupFilename;
diff --git a/src/util/time.cpp b/src/util/time.cpp
index 031367dd51..34eff52c20 100644
--- a/src/util/time.cpp
+++ b/src/util/time.cpp
@@ -151,6 +151,19 @@ std::string FormatISO8601DateTime(int64_t nTime) {
     return strprintf("%04i-%02i-%02iT%02i:%02i:%02iZ", ts.tm_year + 1900, ts.tm_mon + 1, ts.tm_mday, ts.tm_hour, ts.tm_min, ts.tm_sec);
 }
 
+std::string FormatISO8601DateTimeDashSep(int64_t nTime) {
+    struct tm ts;
+    time_t time_val = nTime;
+#ifdef HAVE_GMTIME_R
+    if (gmtime_r(&time_val, &ts) == nullptr) {
+#else
+    if (gmtime_s(&ts, &time_val) != 0) {
+#endif
+        return {};
+    }
+    return strprintf("%04i-%02i-%02iT%02i-%02i-%02iZ", ts.tm_year + 1900, ts.tm_mon + 1, ts.tm_mday, ts.tm_hour, ts.tm_min, ts.tm_sec);
+}
+
 std::string FormatISO8601Date(int64_t nTime) {
     struct tm ts;
     time_t time_val = nTime;
diff --git a/src/util/time.h b/src/util/time.h
index b673c36498..ab73ae4897 100644
--- a/src/util/time.h
+++ b/src/util/time.h
@@ -90,6 +90,7 @@ T GetTime();
  * helper functions if possible.
  */
 std::string FormatISO8601DateTime(int64_t nTime);
+std::string FormatISO8601DateTimeDashSep(int64_t nTime);
 std::string FormatISO8601Date(int64_t nTime);
 int64_t ParseISO8601DateTime(const std::string& str);