Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we change [AcceptToMemoryPool : Unable to connect to inputs ‘n’] from an ‘Error’ to ‘Info’ #2055

Closed
philipswift opened this issue Mar 17, 2021 · 3 comments · Fixed by #2076
Assignees
Milestone

Comments

@philipswift
Copy link

Can we maybe change [AcceptToMemoryPool : Unable to connect to inputs ‘n’] from an ‘Error’ to ‘Info’

This happened to BTC back in 2015 . Source: bitcoin/bitcoin#6518

and they changed it from ‘Error’ to something else. The GridcoinResearch debug log will, of course, show less errors then. Not a biggy ; only 6 of these entries in the last 3 days.

@jamescowens
Copy link
Member

I am fine with that I think.

@jamescowens jamescowens added this to the Ingrid milestone Mar 17, 2021
@jamescowens
Copy link
Member

Quite frankly, we need to do another round of house cleaning on debug logging. I ported the Bitcoin BCLog class over a while back which gives us debug categories that you can turn on and off via the logging command (or debug= in the config), but there are still inappropriate or misclassified logs that need to be adjusted or eliminated. Plus there are areas where logging is NOT being done that need more logging, although it should be under a category, so silenced by default.

My general opinion is that the logging in the older code is quite poor and doesn't provide enough coverage/information to do adequate troubleshooting. When we have categorized logging that is turned off by default, we can be more expansive in the logging for that category. (Essentially this gives us something between the old debug and debug10.) BTW the new terms for the old "debug" and debug10 are the categories "VERBOSE" and "NOISY". :)

@iFoggz
Copy link
Member

iFoggz commented Mar 24, 2021

I agree debugging needs house cleaning for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants