Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove need for System.Threading.Channels in Health Checks package #2401

Closed
thompson-tomo opened this issue Mar 30, 2024 · 0 comments · Fixed by #2402
Closed

Remove need for System.Threading.Channels in Health Checks package #2401

thompson-tomo opened this issue Mar 30, 2024 · 0 comments · Fixed by #2402
Labels
enhancement New feature or request

Comments

@thompson-tomo
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I want to minimise dependencies in my project by utilising framework dependencies wherever possible

Describe the solution you'd like

The System.Threading.Channels package becomes conditional so only added for the older frameworks

Describe alternatives you've considered

Accept the additional dependency

Additional context

n/a
@thompson-tomo thompson-tomo added the enhancement New feature or request label Mar 30, 2024
thompson-tomo added a commit to thompson-tomo/grpc-dotnet that referenced this issue Mar 30, 2024
@thompson-tomo
grpc#2401 Add net core 3 so package dependency can be removed
5a598f6
@thompson-tomo thompson-tomo mentioned this issue Mar 30, 2024
Merged
@thompson-tomo thompson-tomo changed the title Remove needed for System.Threading.Channels in Health Checks package Remove need for System.Threading.Channels in Health Checks package Mar 30, 2024
JamesNK pushed a commit to thompson-tomo/grpc-dotnet that referenced this issue Apr 17, 2024
@thompson-tomo @JamesNK
grpc#2401 Add net core 3 so package dependency can be removed
54c2da5
JamesNK added a commit that referenced this issue Apr 17, 2024
@thompson-tomo @JamesNK
#2401 Add new TFM's so package dependency can be removed (#2402)
c04d01a 
Co-authored-by: James Newton-King <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2401 Add new TFM's so package dependency can be removed thompson-tomo/grpc-dotnet
1 participant
@thompson-tomo