You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the current xds_client, we unmarshall all wire bytes into a v3 message. If regex is set, it will be dropped during unmarshal() (as an unknown message field). So there's no way to check and NACK regex if we keep the current v3 message approach.
We should NACK the response if it has none of the known fields set.
E.g. if path_specifier doesn't have prefix or path or safeRegex (which are what the client knows of, and can change if the client can handle more types later).
Another thing to check in the route: RouteAction_WeightedClusters.
If WeightedClusters has 0 clusters in it, this route is invalid. The whole RDS response should be NACK'ed.
grpc-go/xds/internal/client/client_xds.go
Lines 264 to 275 in bce1fdf
https://github.com/grpc/proposal/blob/master/A28-xds-traffic-splitting-and-routing.md#response-validation
The text was updated successfully, but these errors were encountered: