From 46c1b387fa547038dbfb2f6ecd236ed3e4b757e3 Mon Sep 17 00:00:00 2001 From: John Cormie Date: Thu, 24 Oct 2024 10:52:44 -0700 Subject: [PATCH] Update binderDied() error description to spell out the possibilities for those unfamiliar with Android internals. (#11628) Callers are frequently confused by this message and waste time looking for problems in the client when the root cause is simply a server crash. See b/371447460 for more context. --- .../src/main/java/io/grpc/binder/internal/BinderTransport.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java b/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java index 81eecf975bf..8c428fac98c 100644 --- a/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java +++ b/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java @@ -299,7 +299,7 @@ protected boolean setOutgoingBinder(OneWayBinderProxy binder) { @Override public synchronized void binderDied() { - shutdownInternal(Status.UNAVAILABLE.withDescription("binderDied"), true); + shutdownInternal(Status.UNAVAILABLE.withDescription("Peer process crashed, exited or was killed (binderDied)"), true); } @GuardedBy("this")