Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: wrap adapters #312

Closed
e2 opened this issue May 30, 2015 · 1 comment
Closed

Refactor: wrap adapters #312

e2 opened this issue May 30, 2015 · 1 comment

Comments

@e2
Copy link
Contributor

e2 commented May 30, 2015

Remove the include Celluloid from Listen::Adapter::Base and instead wrap each adapter in a Celluloid class.

Goal: Make it so non-TCP adapters can be used without depending on Celluloid

Reason: tests become simpler and Celluloid independent (easier debugging of crashes) and Listen becomes a little bit faster (because Celluloid queues all method - which is not necessary).
@e2
Copy link
Contributor Author

e2 commented Jun 17, 2015

Superseeded by #319

@e2 e2 closed this as completed Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@e2