-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Listening fails for symlinks pointing outside the listened directory #71
Comments
Got the same results with |
@nex3 could you submit a failing specs for this? It would be great, thanks in advance! |
Mmm after some thinking, I even not quite sure that your example could work because |
This could be handled by Listen itself by manually listening to symlinked directories that lie outside the primary directory. Otherwise clients that care about symlinks will all need to implement that behavior themselves. I'd be happy to add a spec, but I'm not sure where such an integration-y test would go. |
Mmm, this would require a complete analyze on start to detect symlinked directories, it could have a bad performance impact. One another point to consider is new symlinked files/directories added after the start that would need to be listened as well. I think it could theoretically work but sadly I wouldn't have much time this month to try an implementation, but if you want try it your self, I can tell you from where begin. |
btw, we should maybe merge this issue with #25. |
The following code reproduces this for me on Ubuntu, using either the inotify or the polling backend:
The text was updated successfully, but these errors were encountered: