New: Honor displayName in ESM exports (closes gulpjs/gulp#2270) (#189)

gulpjs · Apr 20, 2019 · 190aaeb · 190aaeb
1 parent 2d8a320
commit 190aaeb
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 2 deletions.
diff --git a/lib/shared/register-exports.js b/lib/shared/register-exports.js
@@ -14,7 +14,7 @@ function registerExports(gulpInst, tasks) {
       return;
     }
 
-    gulpInst.task(taskName, task);
+    gulpInst.task(task.displayName || taskName, task);
   }
 }
 

diff --git a/test/expected/tasks-as-exports.txt b/test/expected/tasks-as-exports.txt
@@ -1,7 +1,20 @@
 gulp-cli/test/fixtures/gulpfiles
 ├── build
 ├── clean
-└─┬ dist
+├─┬ dist
+│ └─┬ <series>
+│   ├── clean
+│   └── build
+├── f-test
+├─┬ p
+│ └─┬ <parallel>
+│   ├── p1
+│   └── p2
+├─┬ p-test
+│ └─┬ <parallel>
+│   ├── p1
+│   └── p2
+└─┬ s-test
   └─┬ <series>
     ├── clean
     └── build
diff --git a/test/fixtures/gulpfiles/gulpfile-exports.babel.js b/test/fixtures/gulpfiles/gulpfile-exports.babel.js
@@ -8,3 +8,15 @@ export function clean(){};
 export function build(){};
 export const string = 'no function';
 export const dist = gulp.series(clean, build);
+function p1(){}
+function p2(){}
+export const p = gulp.parallel(p1, p2);
+
+export const sTest = gulp.series(clean, build);
+sTest.displayName = 's-test';
+
+export const pTest = gulp.parallel(p1, p2);
+pTest.displayName = 'p-test';
+
+export function fTest(){};
+fTest.displayName = 'f-test';