Skip to content

Commit

Permalink
Update: Remove lodash.isstring
Browse files Browse the repository at this point in the history
  • Loading branch information
phated committed Dec 21, 2017
1 parent e859ae9 commit 5d2aefd
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 7 deletions.
7 changes: 7 additions & 0 deletions lib/shared/is-string.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
'use strict';

function isString(val) {
return (typeof val === 'string');
}

module.exports = isString;
3 changes: 2 additions & 1 deletion lib/shared/log/tasks.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ var chalk = require('chalk');
var log = require('gulplog');

var sortBy = require('lodash.sortby');
var isString = require('lodash.isstring');
var isObject = require('lodash.isplainobject');

var isString = require('../is-string');

function logTasks(tree, depth, getTask) {
depth = (typeof depth !== 'number') ? null : ((depth < 1) ? 1 : depth);

Expand Down
2 changes: 1 addition & 1 deletion lib/versioned/^3.7.0/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ var chalk = require('chalk');
var log = require('gulplog');
var stdout = require('mute-stdout');
var tildify = require('tildify');
var isString = require('lodash.isstring');

var taskTree = require('./taskTree');
var logTasks = require('../../shared/log/tasks');
var isString = require('../../shared/is-string');
var logEvents = require('./log/events');
var logTasksSimple = require('./log/tasksSimple');
var registerExports = require('../../shared/registerExports');
Expand Down
2 changes: 1 addition & 1 deletion lib/versioned/^4.0.0-alpha.1/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ var log = require('gulplog');
var chalk = require('chalk');
var stdout = require('mute-stdout');
var tildify = require('tildify');
var isString = require('lodash.isstring');

var exit = require('../../shared/exit');
var isString = require('../../shared/is-string');

var logTasks = require('../../shared/log/tasks');
var logEvents = require('../^4.0.0/log/events');
Expand Down
2 changes: 1 addition & 1 deletion lib/versioned/^4.0.0-alpha.2/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ var log = require('gulplog');
var chalk = require('chalk');
var stdout = require('mute-stdout');
var tildify = require('tildify');
var isString = require('lodash.isstring');

var exit = require('../../shared/exit');
var isString = require('../../shared/is-string');

var logTasks = require('../../shared/log/tasks');
var logEvents = require('../^4.0.0/log/events');
Expand Down
2 changes: 1 addition & 1 deletion lib/versioned/^4.0.0/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ var log = require('gulplog');
var chalk = require('chalk');
var stdout = require('mute-stdout');
var tildify = require('tildify');
var isString = require('lodash.isstring');

var exit = require('../../shared/exit');
var isString = require('../../shared/is-string');

var logTasks = require('../../shared/log/tasks');
var logEvents = require('./log/events');
Expand Down
3 changes: 2 additions & 1 deletion lib/versioned/^4.0.0/log/getTask.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
'use strict';

var isString = require('lodash.isstring');
var isObject = require('lodash.isplainobject');
var isFunction = require('lodash.isfunction');

var isString = require('../../../shared/is-string');

function getTask(gulpInst) {
return function(name) {
var task = gulpInst.task(name);
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
"liftoff": "^2.3.0",
"lodash.isfunction": "^3.0.8",
"lodash.isplainobject": "^4.0.4",
"lodash.isstring": "^4.0.1",
"lodash.sortby": "^4.5.0",
"matchdep": "^1.0.0",
"mute-stdout": "^1.0.0",
Expand Down

0 comments on commit 5d2aefd

Please sign in to comment.