Fix: Log requireFail results in yellow on stdout instead of red on stderr (fixes #142) #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phated I think this is good change. I'll review this. |
sttk
suggested changes
Jan 24, 2018
test/exports-as-tasks.js
Outdated
| @@ -21,11 +21,10 @@ describe('exports as tasks', function() { | |||
|
|
|||
| function cb(err, stdout) { | |||
| expect(err).toEqual(null); | |||
| // Skipping stderr expectation because babel broke node 0.10 | |||
| // expect(stderr).toEqual(''); | |||
There was a problem hiding this comment.
By this pr, stderr should become an empty string. Add its check code, please.
test/flags-require.js
Outdated
| expect(err).toEqual(null); | ||
| stderr = eraseLapse(eraseTime(stderr)); | ||
| expect(stderr).toMatch('Failed to load external module ./null-module.js'); |
There was a problem hiding this comment.
By this pr, stderr should become an empty string. Add its check code, please.
phated
force-pushed
the
require-fail-warning
branch
from
2f9d7a3
to
91dbf38
Compare
|
@sttk updated! |
sttk
approved these changes
Jan 24, 2018
|
@phated Perfect! Thanks updating. |
|
I've merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sttk what do you think of this change? It seems like some tools interpret stderr wrong (like
husky) and treat any output as a failure. This change is mostly a cosmetic one but it does change some tests.