-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement .gulprc support #90
Conversation
**--ignore-config** | ||
Ignore configuration files except files specified by --config flag. | ||
|
||
**--output-config** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who/what would use this flag? What is the purpose and benefit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By this flag, users can check the current configurations and get the list of the customizable configurations. Since the configuration set is the result of merging multiple files, it would be useful to check the result. And it would be useful for sharing someone's configurations, for generating single configuration files from multiple configuration files by combining it with --config
flag, and so on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an interesting use case. I think each of these should come later and as separate PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got it. I'll remove these features in this PR and add them later when they are needed.
@phated I've modified the codes. |
@sttk this looks great! Thank you so much for the work on this feature (in Liftoff and here). I'll merge and add some docs before I publish. |
|
Considering shipping this as 1.3.0 and pushing everything else to a 1.4 milestone. |
I see. Thanks for altering and merging. |
This is a PR about the issue #69. This make possible to operate configuration files as below:
--output-config
flag.--config
or-c
flag.--ignore-config
flag, except files specified by--config
flag.In addition, this PR adds some useful test tools in
test/tools
directory (which are tested with files intest/tools/test
directory):run-gulp
: creates and executes a command line string which changes directories and runs gulp with options (and can print the command string, error, stdout and stderr)erase-time
: erases timestamp from each lines in output text.skip-lines
: removes first specified number of lines in output text.