Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement .gulprc support #90

Merged
merged 1 commit into from
Aug 22, 2016
Merged

Implement .gulprc support #90

merged 1 commit into from
Aug 22, 2016

Conversation

sttk
Copy link
Contributor

@sttk sttk commented Aug 10, 2016

This is a PR about the issue #69. This make possible to operate configuration files as below:

  • Load and merge configuration files in home directory, project directory, current work directory if exists.
  • Print configurations in JSON format by --output-config flag.
  • Load and merge configuration files by --config or -c flag.
  • Ignore configuration files by --ignore-config flag, except files specified by --config flag.

In addition, this PR adds some useful test tools in test/tools directory (which are tested with files in test/tools/test directory):

  • run-gulp : creates and executes a command line string which changes directories and runs gulp with options (and can print the command string, error, stdout and stderr)
  • erase-time : erases timestamp from each lines in output text.
  • skip-lines : removes first specified number of lines in output text.

@sttk sttk mentioned this pull request Aug 10, 2016
**--ignore-config**
Ignore configuration files except files specified by --config flag.

**--output-config**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who/what would use this flag? What is the purpose and benefit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By this flag, users can check the current configurations and get the list of the customizable configurations. Since the configuration set is the result of merging multiple files, it would be useful to check the result. And it would be useful for sharing someone's configurations, for generating single configuration files from multiple configuration files by combining it with --config flag, and so on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an interesting use case. I think each of these should come later and as separate PRs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it. I'll remove these features in this PR and add them later when they are needed.

@sttk
Copy link
Contributor Author

sttk commented Aug 21, 2016

@phated I've modified the codes.

@phated
Copy link
Member

phated commented Aug 22, 2016

@sttk this looks great! Thank you so much for the work on this feature (in Liftoff and here). I'll merge and add some docs before I publish.

@phated phated merged commit caa0a82 into gulpjs:master Aug 22, 2016
@phated
Copy link
Member

phated commented Aug 22, 2016

sortBy wasn't actually doing what you thought so I'm altering it to be a map

phated pushed a commit that referenced this pull request Aug 22, 2016
Includes implementation for description configuration (closes #70)
@phated
Copy link
Member

phated commented Aug 23, 2016

Considering shipping this as 1.3.0 and pushing everything else to a 1.4 milestone.

@sttk
Copy link
Contributor Author

sttk commented Aug 23, 2016

sortBy wasn't actually doing what you thought so I'm altering it to be a map

I see. Thanks for altering and merging.

@sttk sttk deleted the support_gulprc branch August 23, 2016 12:14
phated pushed a commit that referenced this pull request Dec 21, 2017
Includes implementation for description configuration (closes #70)
phated pushed a commit that referenced this pull request Dec 21, 2017
Includes implementation for description configuration (closes #70)
phated pushed a commit that referenced this pull request Dec 21, 2017
Includes implementation for description configuration (closes #70)
phated pushed a commit that referenced this pull request Dec 21, 2017
Includes implementation for description configuration (closes #70)
phated pushed a commit that referenced this pull request Dec 21, 2017
Includes implementation for description configuration (closes #70)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants