Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable old media field GraphQL fields by default. #217

Closed
wants to merge 1 commit into from

Conversation

gvkries
Copy link
Owner

@gvkries gvkries commented Aug 9, 2024

OrchardCMS#15003 introduced a new GraphQL type files to group all media item properties together. However, the old fields were left intact, resulting in duplicated fields. This PR removes the old fields by default but provides a compatibility switch to restore them if needed.

As suggested by @sebastienros, I added an AppContext switch to handle this. However, this is the first time we're using an AppContext switch, as far as I can tell. We may need to discuss whether this is the best approach or if we should consider an alternative.

/cc @MikeAlhayek @Piedone @hyzx86

Copy link

github-actions bot commented Aug 9, 2024

Thank you for submitting your first pull request, awesome! 🚀 If you haven't already, please take a moment to review our contribution guide. This guide provides helpful information to ensure your contribution aligns with our standards. A core team member will review your pull request.

If you like Orchard Core, please star our repo and join our community channels.

@gvkries gvkries closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant