Disable old media field GraphQL fields by default. #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrchardCMS#15003 introduced a new GraphQL type
files
to group all media item properties together. However, the old fields were left intact, resulting in duplicated fields. This PR removes the old fields by default but provides a compatibility switch to restore them if needed.As suggested by @sebastienros, I added an
AppContext
switch to handle this. However, this is the first time we're using anAppContext
switch, as far as I can tell. We may need to discuss whether this is the best approach or if we should consider an alternative./cc @MikeAlhayek @Piedone @hyzx86