Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in template_model.add_template() #267

Closed
liunelson opened this issue Dec 19, 2023 · 2 comments
Closed

Bug in template_model.add_template() #267

liunelson opened this issue Dec 19, 2023 · 2 comments

Comments

@liunelson
Copy link

Line 858 of template_model.py needs to be just initials.update(initial_mapping or {})
https://github.com/gyorilab/mira/blob/main/mira/metamodel/template_model.py#L858C17-L858C17

dict.update() always returns None and assigning it back to initials causes this error:
Screenshot 2023-12-19 at 3 01 35 PM
@liunelson
Copy link
Author

It might also be a good idea to expand the unit test for add_template to include parameter_mapping and initial_mapping here: https://github.com/gyorilab/mira/blob/main/tests/test_template.py#L343

@nanglo123 nanglo123 mentioned this issue Dec 19, 2023
Merged
@bgyori
Copy link
Member

bgyori commented Feb 5, 2024

Fixed in #268

@bgyori bgyori closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liunelson @bgyori