Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No protocol check, freeze if invalid port number provided #1

Open
wilsonlmh opened this issue Oct 27, 2014 · 0 comments
Open

No protocol check, freeze if invalid port number provided #1

wilsonlmh opened this issue Oct 27, 2014 · 0 comments

Comments

@wilsonlmh
Copy link

I found a big issue that the API freeze if I provided a wrong port number(but the port can reach some other service, e.g. HTTP or API-ssl). I don't good at that programming skills, but I did a trace so maybe you can figure out faster.

ros_login() -> line#809 ros_send_command_wait() -> line#795 ros_read_packet(conn) -> line#491 readLen(conn) -> line#125 _read()

The program freeze here (line#125). I tried HTTP and API-ssl both act same. Since I'm doing a command line tools. It's easy for ppl to type a incorrect port number(like 8278, 8729 etc.). I think it may have a check. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant