Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vaultfs): Support KVv2 mounts that contain slashes #738

Merged
merged 1 commit into from
Jun 30, 2024
Merged

fix(vaultfs): Support KVv2 mounts that contain slashes #738

merged 1 commit into from
Jun 30, 2024

Conversation

hairyhenderson
Copy link
Owner

Fixes #730

  • now caches the matching mount from the sys/internal/ui/mounts in the file
  • uses the KVv2 client directly instead of making a raw request and munging the path

@hairyhenderson hairyhenderson added the bug Something isn't working label Jun 30, 2024
@hairyhenderson hairyhenderson self-assigned this Jun 30, 2024
@hairyhenderson hairyhenderson force-pushed the support-mounts-with-slashes-730 branch 2 times, most recently from 87675d8 to 38f88ef Compare June 30, 2024 00:42
@hairyhenderson hairyhenderson force-pushed the support-mounts-with-slashes-730 branch from 38f88ef to 35ce757 Compare June 30, 2024 00:43
@hairyhenderson hairyhenderson mentioned this pull request Jun 30, 2024
Closed
@hairyhenderson hairyhenderson merged commit 87b1367 into main Jun 30, 2024
17 checks passed
@hairyhenderson hairyhenderson deleted the support-mounts-with-slashes-730 branch June 30, 2024 00:50
@hairyhenderson-bot hairyhenderson-bot bot mentioned this pull request Jun 30, 2024
Merged
hairyhenderson added a commit that referenced this pull request Jun 30, 2024
@hairyhenderson
fix(vaultfs): bug when Stat builds mount info from #738
c8a9a9c 
Signed-off-by: Dave Henderson <[email protected]>
@hairyhenderson hairyhenderson mentioned this pull request Jun 30, 2024
Merged
hairyhenderson added a commit that referenced this pull request Jun 30, 2024
@hairyhenderson
fix(vaultfs): bug when Stat builds mount info from #738
afa1257 
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson added a commit that referenced this pull request Jun 30, 2024
@hairyhenderson
fix(vaultfs): bug when Stat builds mount info from #738 (#739)
83a8196 
Signed-off-by: Dave Henderson <[email protected]>
@hairyhenderson hairyhenderson mentioned this pull request Jun 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hairyhenderson hairyhenderson

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vaultfs mangles paths for KV v2 mounts that contain slashes
1 participant
@hairyhenderson