feat(blobfs): Use AWS SDK v2 for blobfs #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
force-pushed
the
use-aws-sdk-v2-for-blobfs
branch
from
b956b45 to
1b71146
Compare
hairyhenderson
changed the title
hairyhenderson
force-pushed
the
use-aws-sdk-v2-for-blobfs
branch
2 times, most recently
from
22cb0cb to
e9f8c36
Compare
|
This is going to be a bit more awkward at the moment, because supporting anonymous S3 access (currently done by setting I've filed google/go-cloud#3512, but will see about hacking around it for now... |
hairyhenderson
force-pushed
the
use-aws-sdk-v2-for-blobfs
branch
from
e9f8c36 to
e54fa68
Compare
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
use-aws-sdk-v2-for-blobfs
branch
from
e54fa68 to
5922c98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to AWS SDK v2 for the S3 support in
blobfs.This changes somewhat the query parameters recognized in URLs, which have been updated in
url_schemes.md.In addition to still supporting the undocumented
AWS_ANONenv var, this adds support for ananonymous=truequery parameter to remove the need to set environment variables. That may be removed if google/go-cloud#3512 is fulfilled with a different query parameter, so it's documented as experimental.