Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.11.3 release build failed to build against go1.20 #1614

Closed
chenrui333 opened this issue Feb 3, 2023 · 4 comments
Closed

3.11.3 release build failed to build against go1.20 #1614

chenrui333 opened this issue Feb 3, 2023 · 4 comments

Comments

@chenrui333
Copy link

👋 while regression testing go1.20 upgrade, I ran into the following error:

==> /opt/homebrew/Cellar/gomplate/3.11.3/bin/gomplate --version
panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.20 runtime. If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.20 set. Notably, if go1.20 adds a moving garbage collector, this program is unsafe to use.

goroutine 1 [running]:
go4.org/unsafe/assume-no-moving-gc.init.0()
	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/go4.org/unsafe/[email protected]/untested.go:25 +0x178

full build log, https://pipelines.actions.githubusercontent.com/serviceHosts/d065b819-d194-4baa-bc84-7b4a294d8693/_apis/pipelines/1/runs/564571/signedlogcontent/19?urlExpires=2023-02-03T17%3A06%3A38.0355252Z&urlSigningMethod=HMACV1&urlSignature=pSX%2FY%2FAHvb9NFrLSm1xQHLgwZ%2FwQ5NinBMs1z6lh5sI%3D

@hairyhenderson
Copy link
Owner

@chenrui333 yeah - gomplate 3.11.3 is definitely not Go 1.20 compatible.

It should (in theory?) work from main, but I'm not ready to cut a new release yet.

Can we keep this on Go 1.19 for now?

@chenrui333
Copy link
Author

yeah, totally, raising the issue mostly for awareness. :)

@hairyhenderson
Copy link
Owner

ok, thanks! 🙇‍♂️

@chenrui333 chenrui333 changed the title 3.11.3 release build failed to run against go1.20 3.11.3 release build failed to build against go1.20 Feb 3, 2023
@hairyhenderson
Copy link
Owner

Fixed in #1641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants