feat(config): Allow avoiding reading default config file #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
force-pushed
the
skip-config-file-if-empty-config-flag-2202
branch
from
e6e5d22 to
0054e25
Compare
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
skip-config-file-if-empty-config-flag-2202
branch
from
eecbf19 to
8cf6bc9
Compare
hairyhenderson
deleted the
skip-config-file-if-empty-config-flag-2202
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2202 the root issue was that the user was running in an unreadable working directory, and so gomplate errored with a message like:
Rather than ignore errors when the default config file can't be read (which will hide real failures and perform the wrong behaviour potentially), this PR adds the ability to set
--configor$GOMPLATE_CONFIGto an empty string, which will cause the config file parsing code to be skipped entirely.