Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reading from AWS SSM Parameter Store? #245

Closed
tyrken opened this issue Jan 30, 2018 · 6 comments
Closed

Enable reading from AWS SSM Parameter Store? #245

tyrken opened this issue Jan 30, 2018 · 6 comments

Comments

@tyrken
Copy link

tyrken commented Jan 30, 2018

I'm looking into using gomplate to fill in values from the AWS Parameter Store, any other interest or guidance as I'm currently hacking it to do so.

Would mean a bump up of the AWS package version to 1.10.x at least, and the re-run of dep ensure is adding a load of files to the repo unless I enable prune options...

@hairyhenderson
Copy link
Owner

@tyrken this sounds like a great feature! Sounds like you're already working on a PR?

As for the pruning - yeah, I was actually working earlier today on updating the Gopkg.toml to support the new prune option. I don't remember why I locked the AWS SDK - probably just annoyed that it kept getting updated 😉 - I'll bump that version as well.

@hairyhenderson
Copy link
Owner

@tyrken ok, deps updated in #246 and #247 - should help!

Were you planning on implementing this as a datasource? I think that may be what makes the most sense.

@tyrken
Copy link
Author

tyrken commented Jan 30, 2018

I have started - but by creating an aws.SSMParam function as a sibling to aws.EC2Tag, roughly working but needs more tests.

On the DataSource front, SSM in design sounds like it might fit in libkv but they don't have AWS SSM Parameter support upstream... don't know how long it would take to get accepted there. Do you want me to add a AWS SSM client to data.Source struct?

@tyrken
Copy link
Author

tyrken commented Jan 30, 2018

On second thoughts, no SSM wouldn't fit in libkv - it cannot satisfy their backend requirements (Watching/Atomic ops). So looking at adding via a new 'aws+ssm+param' sourceReader

@tyrken
Copy link
Author

tyrken commented Jan 30, 2018

Initial work in PR - #248

@hairyhenderson
Copy link
Owner

Fixed in #248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants