Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trade the dependency on aws-sdk-go for something smaller #47

Closed
hairyhenderson opened this issue May 19, 2016 · 2 comments
Closed

Trade the dependency on aws-sdk-go for something smaller #47

hairyhenderson opened this issue May 19, 2016 · 2 comments
Assignees

Comments

@hairyhenderson
Copy link
Owner

The AWS functions (ec2tag, ec2meta, etc...) add a lot of size to the binary (something like 13MBs, though less when UPX-compressed), can slow things down, and aren't always used...

A whole plugin architecture may be overkill for this project, but some way of lessening the impact would be useful.

Alternatively a much lighter-weight client for the EC2 API calls would help.

@hairyhenderson
Copy link
Owner Author

A year later and this honestly hasn't seemed to be too much of a problem... I still think a lighter-weight client would be handy, though.

@hairyhenderson hairyhenderson changed the title Split the AWS-dependent functions into a separate module/plugin Trade the dependency on aws-sdk-go for something smaller Jun 4, 2017
@hairyhenderson
Copy link
Owner Author

Since I logged this, a few things have changed:

  • more AWS functionality is being used and added
  • the slowdowns have been addressed
  • I think most people use the slim binaries (though maybe not all)

I'm going to close this for now. It may be necessary/useful to adopt a plugin system at some point, especially as more and more functions and datasources are added. But it's not time yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant