Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tests jshandle.spec.ts #1740

Closed
kblok opened this issue Jul 3, 2021 · 0 comments · Fixed by #1815
Closed

Add missing tests jshandle.spec.ts #1740

kblok opened this issue Jul 3, 2021 · 0 comments · Fixed by #1815
Labels
puppeteer code Features/Features from Puppeteer

Comments

@kblok
Copy link
Member

kblok commented Jul 3, 2021

jshandle.spec.ts: Page.evaluateHandle: should work
jshandle.spec.ts: Page.evaluateHandle: should accept object handle as an argument
jshandle.spec.ts: Page.evaluateHandle: should accept object handle to primitive types
jshandle.spec.ts: Page.evaluateHandle: should warn on nested object handles
jshandle.spec.ts: Page.evaluateHandle: should accept object handle to unserializable value
jshandle.spec.ts: Page.evaluateHandle: should use the same JS wrappers
jshandle.spec.ts: Page.evaluateHandle: should work with primitives
jshandle.spec.ts: JSHandle.jsonValue: works with jsonValues that are not objects
jshandle.spec.ts: JSHandle.jsonValue: works with jsonValues that are primitives
jshandle.spec.ts: JSHandle.toString: should work with different subtypes
@kblok kblok added the puppeteer code Features/Features from Puppeteer label Jul 3, 2021
kblok added a commit that referenced this issue Sep 27, 2021
@kblok
Add missing JSHandle tests
9bd0508 
closes #1740
@kblok kblok mentioned this issue Sep 27, 2021
Merged
kblok added a commit that referenced this issue Sep 27, 2021
@kblok
Add missing JSHandle tests (#1815)
3d5eaec 
closes #1740
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
puppeteer code Features/Features from Puppeteer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing JSHandle tests hardkoded/puppeteer-sharp
1 participant
@kblok