feat: Add support for the Jekyll sample filter #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harttle
reviewed
May 23, 2023
See https://jekyllrb.com/docs/liquid/filters I am sorting the array randomly and then picking the first N items or all items if there is no sample limit.
Typo and copy-paste meet
TomasHubelbauer
force-pushed
the
tom/sample
branch
from
f4a5a3a to
05e942d
Compare
TomasHubelbauer
commented
May 25, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jun 3, 2023
# [10.8.0](v10.7.1...v10.8.0) (2023-06-03) ### Bug Fixes * proper error message for filter syntax error, [#610](#610) ([0480d33](0480d33)) * sed invocations to work out of the box on macOS ([#615](#615)) ([87d4cc7](87d4cc7)) ### Features * Add support for the Jekyll sample filter ([#612](#612)) ([ba8b842](ba8b842)) * introduce a matrix with latest Ubuntu and macOS to test the build on macOS as well ([82ba548](82ba548)), closes [#615](#615) * precise line/col for tokenization Error, [#613](#613) ([e347e60](e347e60))
|
🎉 This PR is included in version 10.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I find it's not consisitent with Jekyll's implementation lib/jekyll/filters.rb#L355. Changed a bit in fcb930f
|
|
Thank you for the fixes! Good idea to go by the Jekyll source code, I will do that next time I am adding a new filter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://jekyllrb.com/docs/liquid/filters
I am sorting the array randomly and then picking the first N items or all items if there is no sample limit.