Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create test to validate contract admin key in hollow account finalized as contract #1007

Closed
lukelee-sl opened this issue Nov 8, 2024 · 0 comments · Fixed by #1142
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@lukelee-sl
Copy link
Member

Problem

As of 0.56 of services, hollow account that are finalized as contracts should have a self managed admin key (i.e. key=contract(0.0.x) where x is the contract id of the new contract.)

There is no test to validate this.

Solution

Write a test that

  • creates a hollow account
  • finalizes it as a contract (contract create transaction signed by the private key of the hollow account)
  • calls getContractinfo to check that the admin key is a contract key of value 0.0.x where x is the hedera contract id number.

Alternatives

No response

@lukelee-sl lukelee-sl added the enhancement New feature or request label Nov 8, 2024
@Nana-EC Nana-EC moved this from Backlog to Sprint Backlog in Smart Contract Sprint Board Nov 25, 2024
@nadezhdapopovaa nadezhdapopovaa self-assigned this Dec 5, 2024
@nadezhdapopovaa nadezhdapopovaa moved this from Sprint Backlog to Tasks In Progress in Smart Contract Sprint Board Dec 5, 2024
@github-project-automation github-project-automation bot moved this from Tasks In Progress to Done in Smart Contract Sprint Board Dec 6, 2024
@nadezhdapopovaa nadezhdapopovaa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2024
@github-project-automation github-project-automation bot moved this from Done to Sprint Backlog in Smart Contract Sprint Board Dec 6, 2024
@nadezhdapopovaa nadezhdapopovaa moved this from Sprint Backlog to Tasks In Progress in Smart Contract Sprint Board Dec 6, 2024
@quiet-node quiet-node added this to the 0.12.0 milestone Jan 6, 2025
@nadezhdapopovaa nadezhdapopovaa moved this from Tasks In Progress to In Review in Smart Contract Sprint Board Jan 7, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in Smart Contract Sprint Board Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
3 participants