Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc-go dependency to allow writing plugins in nodejs / rust over UDS #153

Closed
entropitor opened this issue Jul 22, 2020 · 3 comments

Comments

@entropitor
Copy link

Due to a bug in grpc-go (grpc/grpc-go#2628), it's impossible to write a grpc server over Unix domain sockets (UDS) with go as a client because it sets the :authority header value to an unsupported value according to the HTTP2 spec, this should be fixed now and supported in an upcoming release

@callensm
Copy link

I'm also trying to write a plugin in Rust but getting:

Error enabling: Error making API request.

URL: POST http://localhost:8200/v1/sys/mounts/test-plugin
Code: 400. Errors:

* rpc error: code = Unknown desc = OK: HTTP status code 200; transport: missing content-type field

every time I run vault secrets enable test-plugin

@entropitor
Copy link
Author

Would this be a hard dependency to bump @mitchellh? Because the longer it takes to bump here, the longer it takes to bump in the different HashiCorp applications, the less versions of those applications plugins in different languages will be able to support.

@tomhjp
Copy link
Contributor

tomhjp commented Oct 11, 2023

Sorry this went unanswered for so long, it looks like d61bc34 addressed this by bumping from v1.27.1 -> v1.38.0, and AFAICT the fix was first released in v1.31? Feel free to reopen if it's not resolved though. Thanks for raising the issue!

@tomhjp tomhjp closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants