Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command/debug: capture more logs by default #23850

Merged
merged 3 commits into from
Aug 22, 2024
Merged

command/debug: capture more logs by default #23850

merged 3 commits into from
Aug 22, 2024

Conversation

20sr20
Copy link
Contributor

@20sr20 20sr20 commented Aug 21, 2024

This PR changes nomad operator debug's default behavior to include more logs. Specifically:

  1. Increase the default duration to 5 minutes.
  2. Capture the logs at TRACE level by default.

Jira: NET-10281

@20sr20 20sr20 self-assigned this Aug 21, 2024
@schmichael schmichael changed the title Nomad-NET-9394 command/debug: capture more logs by default Aug 22, 2024
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I updated the docs, PR comment+title, and added a changelog entry. Feel free to use our little make cl tool to help you add a changelog to any future PRs.

@schmichael schmichael added backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent labels Aug 22, 2024
@20sr20
Copy link
Contributor Author

20sr20 commented Aug 22, 2024

Thank you @schmichael for the review.

@20sr20 20sr20 merged commit 36522ec into main Aug 22, 2024
30 checks passed
@20sr20 20sr20 deleted the Nomad-NET-9394 branch August 22, 2024 17:43
@jrasell jrasell mentioned this pull request Sep 19, 2024
@shoenig shoenig added the backport/1.8.x backport to 1.8.x release line label Sep 19, 2024
shoenig pushed a commit that referenced this pull request Sep 19, 2024
shoenig pushed a commit that referenced this pull request Sep 20, 2024
…1.8.x (#24014)

* Nomad Default to 5m duration and trace-level logging

* docs: update defaults for operator debug

* docs: add cl for #23850

---------

Co-authored-by: Sujata Roy <[email protected]>
Co-authored-by: Michael Schurter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.8.x backport to 1.8.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants