Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alloc exec leaks a goroutine on exit #24242

Closed
tgross opened this issue Oct 17, 2024 · 0 comments · Fixed by #24244
Closed

alloc exec leaks a goroutine on exit #24242

tgross opened this issue Oct 17, 2024 · 0 comments · Fixed by #24244

Comments

@tgross
Copy link
Member

tgross commented Oct 17, 2024

On Nomad 1.9.0, upon exiting an alloc exec, we're leaking a goroutine:

goroutine 1417 [select]:
io.(*pipe).read(0xc0011ff980, {0xc001956000, 0x8000, 0x473201?})
    io/pipe.go:57 +0xa5
io.(*PipeReader).Read(0x4aa0840?, {0xc001956000?, 0xc001c4b750?, 0x14d92f5?})
    io/pipe.go:134 +0x1a
io.copyBuffer({0x3387400, 0xc0014e45e8}, {0x3383d80, 0xc0011ff980}, {0x0, 0x0, 0x0})
    io/io.go:429 +0x191
io.Copy(...)
    io/io.go:388
github.com/hashicorp/nomad/drivers/docker.(*Driver).ExecTaskStreaming.func3()
    github.com/hashicorp/nomad/drivers/docker/driver.go:1850 +0x7a
created by github.com/hashicorp/nomad/drivers/docker.(*Driver).ExecTaskStreaming in goroutine 1407
    github.com/hashicorp/nomad/drivers/docker/driver.go:1849 +0x69f

This looks superficially similar to what we're fixing in #24202 but appear to be a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants