Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set NODE_ENV for CLI #129

Closed
skorfmann opened this issue Jul 2, 2020 · 1 comment · Fixed by #148
Closed

Set NODE_ENV for CLI #129

skorfmann opened this issue Jul 2, 2020 · 1 comment · Fixed by #148
Labels
enhancement New feature or request

Comments

@skorfmann
Copy link
Contributor

According to some issues in the ink project, the env variable NODE_ENV should be set to production when distributing the cli. This will suppress error output from React itself.

We should set this as part of the release somehow, and make it overwritable. So, when the user set NODE_ENV to something else, it should be respected.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant