Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Name Structure in Diff / Deploy / Destroy #135

Closed
skorfmann opened this issue Jul 5, 2020 · 2 comments · Fixed by #165
Closed

Resource Name Structure in Diff / Deploy / Destroy #135

skorfmann opened this issue Jul 5, 2020 · 2 comments · Fixed by #165

Comments

@skorfmann
Copy link
Contributor

Given the following stack with a construct EcrAsset which will create two resources:

class FargateWebService extends TerraformStack {
  constructor(scope: Construct, name: string) {
    super(scope, name);

    new AwsProvider(this, 'Main', {
      region: AwsRegions.frankfurt.code
    })

    new EcrAsset(this, 'WebApp', {
      folder: path.join(__dirname, './web-app')
    })

  }
}

This is the current output:

Screenshot 2020-07-05 at 21 51 11

I think in general, rather than fargatewebservice_W (which is the stack name), we would probably want to see dockerAsset / buildAndPush. Thoughts?

@anubhavmishra
Copy link
Member

Yes, ideally we want to see the WebApp_dockerAsset and WebApp_buildAndPush.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants