-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java support #360
Java support #360
Conversation
There might be some instability in running the examples integration task. I'm not sure if https://github.com/hashicorp/terraform-cdk/pull/360/checks?check_run_id=1096559302 was a one off, or if we need to bootstrap the maven repo or have each example use its own cache. |
Looks like that is the case. I'll have to think about this some more. Once https://issues.apache.org/jira/browse/MRESOLVER-131 is finished, this could get easier. |
I decided to just not run the java examples in parallel for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides from Maven credentials for the Github action, is there anything else missing to get this merged @jsteinich ?
I think that's all we need. |
@anubhavmishra could you create these credentials and add them as secrets for actions? |
I started working on getting an account to publish to Maven Central. It requires a bunch of changes to allow Sonatype to verify our account. It does require work so I will get back to you on this one. |
We'll look into github package registry as a temporary way to publish the packages |
Just looked into it some. Seems like they still don't support anonymous package download which will make it quite annoying to use. Would publishing the artifacts not under hashicorp make the maven central setup easier? Or you using jcenter or some other repo? |
Oh, yeah - that's bad https://docs.github.com/en/free-pro-team@latest/packages/publishing-and-managing-packages/installing-a-package
What options do you see there? |
I haven't personally published to maven central, but the instructions seem pretty simple so I'm wondering if existing hashicorp accounts are complicating things. Maybe something like |
71bba6e
to
396cecf
Compare
I updated the release workflow to publish to GitHub packages rather than maven central and left a note about it in the Java getting started guide. |
Awesome stuff! Thank you so much for contributing this 🚀 |
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Closes #197
Adds:
Setting up the maven keys and profile is probably best left to the internal team.