Generated custom mappings

[jsteinich]

Initial goal is to fix #235 but I may expand to pick up #223, #234, #282.

The representation of attribute types and how that applies to the generation and dependencies is definitely a bit messy and brittle, but I don't have any suggestions at this point on how to improve.

[jsteinich]

Going to put any additional fixes in follow up PRs.
Also holding off on doing any refactoring.

[jsteinich]

Realized this already picks up a fix for #282.

[skorfmann]

I may expand to pick up #223, #234, #282.
Realized this already picks up a fix for #282.

Have you started to work on #223 / #234 already?

[jsteinich]

Have you started to work on #223 / #234 already?

I have not. Feel free to work on them if you'd like.

[kaisellgren]

This does not work:

new CloudRunService(s, 'a', {
  template: [
    {
      metadata: [
        {
          annotations: {
            'autoscaling.knative.dev/maxScale': '1000',
            'run.googleapis.com/cloudsql-instances': 'name',
            'run.googleapis.com/sandbox': 'gvisor',
          }
        }
      ]
    },
  ],
})

Those annotations will be converted to:

{
  "metadata": [
    {
      "annotations": {
        "autoscaling_knative_dev_max_scale": "1000",
        "run_googleapis_com_cloudsql_instances": "name",
        "run_googleapis_com_sandbox": "gvisor"
      }
    }
  ]
}

How do I prevent it from converting dots to underscores? The only way I can seem to do it is by using the escape hatch:

gcr.addOverride("template.0.metadata", [
  {
    annotations: {
      "autoscaling.knative.dev/maxScale": "1000",
      "run.googleapis.com/cloudsql-instances": 'name',
      "run.googleapis.com/sandbox": "gvisor",
    },
  },
])

It would be great if this worked without the escape hatch, but I can live with this for now.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.