Alter reset and input names when they conflict #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this good to merge? |
jsteinich
force-pushed
the
reset_and_input_check
branch
from
8a901b2 to
8b8bd3e
Compare
@skorfmann I rebased against master and fixed the new test snapshot. Should be good to go now assuming full tests still pass. |
Merged
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427
Very rarely, the generated names for resetting optional values and accessing the input value for required or optional values conflicts with other values.
I checked nearly 400 providers and found only 3 instances of conflict with
resetand 1 withinput. As such, I choose to only diverge from convention when necessary rather than changing the naming overall.XInput->XTfInputandresetX->resetTfX